Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted to npm version. Handle ports array, optional host. Backward compatible. Added Tests. #36

Closed
wants to merge 4 commits into from

Conversation

elmccd
Copy link
Contributor

@elmccd elmccd commented Nov 15, 2015

I reverted version to one published in npm c2092ce and applied commits created in meantime which don't break code.

Actual master is really messed up.

Added support for arrays of ports to check, instead of range. #18 #26
It's based on parameters type so we it's still compatible with actual version.

Tests for all methods.

npm install
npm test

@laggingreflex
Copy link
Collaborator

laggingreflex commented Nov 18, 2016

Sorry about the delay on this.

I've divided this into #43 #44 #45 and merged them in. Closing this.

Thanks very much @elmccd for your contribution! Will publish a new version soon.

@laggingreflex
Copy link
Collaborator

Released a new minor version 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants